Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions - check-files workflow - split into steps as a workaround for step template size limit #3276

Merged
merged 2 commits into from
May 21, 2023
Merged

GitHub Actions - check-files workflow - split into steps as a workaround for step template size limit #3276

merged 2 commits into from
May 21, 2023

Conversation

gorbunovav
Copy link
Contributor

@gorbunovav gorbunovav commented May 19, 2023 •
edited by ADDISON74
Loading

Description (*)

Splits check-files job into more steps to workaround the template size limit issue.

Fixed Issues (if relevant)

Fixes #3275

Manual testing scenarios (*)

  1. Create a PR with several thousands of changed files
  2. Check that check-files job has completed succesfully and emits relevant output values

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@gorbunovav gorbunovav marked this pull request as ready for review May 19, 2023 13:52
@fballiano
Copy link
Contributor

hi @gorbunovav and thanks for your PR, could you rebase it on the "main" branch?

@gorbunovav
Refs OpenMage#3275: GitHub Actions - check-files workflow - split i…
7c9e8e3 
…nto steps as a workaround for step template size limit
@gorbunovav gorbunovav force-pushed the githubactions-fix-for-large-changed-files-number branch from 84e47a0 to 7c9e8e3 Compare May 19, 2023 14:26
@gorbunovav gorbunovav changed the base branch from 1.9.4.x to main May 19, 2023 14:26
@gorbunovav
Copy link
Contributor Author

@fballiano done

@ADDISON74
Copy link
Contributor

You may add yourself to the list of contributors, if your name doesn't appear yet.

@github-actions github-actions bot removed PHPStorm Component: Cm/RedisSession Relates to Cm_RedisSession phpunit Component: Adminhtml Relates to Mage_Adminhtml ddev htaccess Mage.php Relates to app/Mage.php phpstan phpcs Component: AdminNotification Relates to Mage_AdminNotification Component: Admin Relates to Mage_Admin labels May 19, 2023
elidrissidev
elidrissidev approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@elidrissidev elidrissidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the output of this PR.

@fballiano
Copy link
Contributor

everything seems ok but I don't have the knowledge on this topic to test it properly

sreichel
sreichel approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought error came from previous step ...

Split grep commands into steps does not hurt ... untested,

@fballiano
Copy link
Contributor

I guess we've no real way to test it so let's merge it, since it is approved, and see

@fballiano fballiano merged commit 58be830 into OpenMage:main May 21, 2023
@gorbunovav gorbunovav deleted the githubactions-fix-for-large-changed-files-number branch May 21, 2023 11:11
@fballiano fballiano mentioned this pull request May 23, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

@Flyingmana Flyingmana Awaiting requested review from Flyingmana

@tmotyl tmotyl Awaiting requested review from tmotyl

@fballiano fballiano Awaiting requested review from fballiano

@kiatng kiatng Awaiting requested review from kiatng

Assignees
No one assigned
Labels
documentation environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions - check-files job fails in case of large number of changed files
5 participants
@gorbunovav @fballiano @ADDISON74 @sreichel @elidrissidev